perf: mico optimisation of number validation

Tom-Hudson · Feb 11, 2025 · 23d5f35 · 23d5f35
1 parent f7594d7
commit 23d5f35
Showing 1 changed file with 6 additions and 61 deletions.
diff --git a/src/validate.ts b/src/validate.ts
@@ -47,67 +47,12 @@ export const validate = (nino: string): ValidateResult => {
     }
   }
 
-  if (validNumbersObj[nino[2]] !== true) {
-    return {
-      rules: {
-        type: true,
-        length: true,
-        prefix: true,
-        number: false
-      },
-      outcome: false
-    }
-  }
-
-  if (validNumbersObj[nino[3]] !== true) {
-    return {
-      rules: {
-        type: true,
-        length: true,
-        prefix: true,
-        number: false
-      },
-      outcome: false
-    }
-  }
-
-  if (validNumbersObj[nino[4]] !== true) {
-    return {
-      rules: {
-        type: true,
-        length: true,
-        prefix: true,
-        number: false
-      },
-      outcome: false
-    }
-  }
-
-  if (validNumbersObj[nino[5]] !== true) {
-    return {
-      rules: {
-        type: true,
-        length: true,
-        prefix: true,
-        number: false
-      },
-      outcome: false
-    }
-  }
-
-  if (validNumbersObj[nino[6]] !== true) {
-    return {
-      rules: {
-        type: true,
-        length: true,
-        prefix: true,
-        number: false
-      },
-      outcome: false
-    }
-  }
-
-  if (validNumbersObj[nino[7]] !== true) {
+  if (validNumbersObj[nino[2]] !== true ||
+    validNumbersObj[nino[3]] !== true ||
+    validNumbersObj[nino[4]] !== true ||
+    validNumbersObj[nino[5]] !== true ||
+    validNumbersObj[nino[6]] !== true ||
+    validNumbersObj[nino[7]] !== true) {
     return {
       rules: {
         type: true,