Support foregroundColor for TextField
#453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carson-katri
added
SwiftUI compatibility
|
The CI failure is fixed by #454, which has been merged. |
MaxDesiatov
changed the title
TextField
MaxDesiatov
changed the title
TextFieldforegroundColor for TextField
|
Great, thanks! |
MaxDesiatov
reviewed
Oct 24, 2021
| public var textFieldStyle: _AnyTextFieldStyle { subject.environment.textFieldStyle } | ||
| public var foregroundColor: AnyColorBox.ResolvedValue? { | ||
| guard let style = subject.environment._foregroundStyle else { return nil } | ||
| var shape = _ShapeStyle_Shape( |
There was a problem hiding this comment.
I'm a bit confused why ShapeStyle specifically is used here. Could you clarify that in code comments?
|
@carson-katri I'm thinking of tagging a new version in the next few days with support for |
|
I should be able to get this finished up either tonight or tomorrow. |
|
No rush, many thanks for your contributions! 🙂 |
|
Releasing 0.9.0 today, but I'm happy to tag 0.9.1 or whatever patch release would include this fix, when it's ready. |
MaxDesiatov
force-pushed
the
textfield-color
branch
from
17dfae7 to
554c0b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.