Add scaleEffect modifier
#424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carson-katri
added
SwiftUI compatibility
carson-katri
force-pushed
the
aspect-ratio
branch
3 times, most recently
from
1f0c8f6 to
3e5568e
Compare
carson-katri
force-pushed
the
scale-effect
branch
from
d75e6a8 to
4f2989c
Compare
MaxDesiatov
reviewed
Jul 12, 2021
|
|
||
| extension _ScaleEffect: DOMViewModifier { | ||
| public var attributes: [HTMLAttribute: String] { | ||
| ["style": "transform: scale(\(scale.width), \(scale.height));"] |
There was a problem hiding this comment.
Does this mean that anchor property has no effect in the HTML renderer?
There was a problem hiding this comment.
Oh, yes. I'll add the transform-origin property.
There was a problem hiding this comment.
I fixed the rotationEffect modifier as well.
carson-katri
force-pushed
the
scale-effect
branch
from
b4fb672 to
fdd37ec
Compare
MaxDesiatov
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the
scale()CSS transform in the HTML/DOM renderers.