Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiline Text and multilineTextAlignment(_:) #401

Merged
merged 1 commit into from
May 13, 2021
Merged

Multiline Text and multilineTextAlignment(_:) #401

merged 1 commit into from
May 13, 2021

Conversation

carson-katri
Copy link
Member

This adds support for multiline Text in the static HTML renderer by adding <br> tags in place of each \n.

It also adds the multilineTextAlignment(_:) modifier, and EnvironmentValues.multilineTextAlignment.

@carson-katri carson-katri added bug Something isn't working SwiftUI compatibility Tokamak API differences with SwiftUI labels May 13, 2021
@MaxDesiatov MaxDesiatov linked an issue May 13, 2021 that may be closed by this pull request
Multi-line string handling in Text views #400
Closed
@carson-katri carson-katri requested a review from a team May 13, 2021 16:06
foscomputerservices
foscomputerservices approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@foscomputerservices foscomputerservices left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

MaxDesiatov
MaxDesiatov approved these changes May 13, 2021
View reviewed changes
Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

@carson-katri carson-katri merged commit 096ec5c into main May 13, 2021
@carson-katri carson-katri deleted the multiline-text branch May 13, 2021 18:03
@disc0infern0
Copy link

Wow. You guys are fast. Awesome work, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

@foscomputerservices foscomputerservices foscomputerservices approved these changes

Assignees
No one assigned
Labels
bug Something isn't working SwiftUI compatibility Tokamak API differences with SwiftUI
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi-line string handling in Text views
4 participants
@carson-katri @disc0infern0 @MaxDesiatov @foscomputerservices