Fix compatibility with JavaScriptKit 0.7 #281
Merged
+238
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
I can no longer reproduce the performance regression. |
|
The CI failure was caused by some issues with GitHub Actions, now ready for review 🙂 |
kateinoigakukun
approved these changes
Sep 29, 2020
MaxDesiatov
added a commit
to swiftwasm/OpenCombineJS
that referenced
this pull request
Sep 30, 2020
`JSScheduler` is copied from TokamakUI/Tokamak#281. You can see the `JSPromise` publisher in action in combination with `fetch` by running `carton dev` in the root directory. I saw some issues with `JSValueDecoder`, which is why it's not used in this PR. I will investigate `JSValueDecoder` issues separately. * Add `JSScheduler` and `JSPromise` publisher * Clean up publisher signature in `main.swift` * Capture `self` weakly in `PromisePublisher.init`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires
carton0.6.0 that you can install from Homebrew as usual.To cleanly manage scheduler closures, new
JSSchedulerclass is introduced that conforms to OpenCombine'sSchedulerprotocol. I think it will be moved to OpenCombineJS in the future.Basic things seem to work, but I think there's a noticeable performance regression somewhere. When I switch between navigation views, it takes almost a second to load everything. I've been staring at profiling data for a bit,JSStringwhich was introduced in JavaScriptKit 0.7 is there somewhere, but I'm not sure what exactly is the culprit yet.Update: I no longer can get the performance regression reproduced. 🤷♂️