Re-export HTML type in TokamakDOM
#275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
reviewed
Sep 22, 2020
|
@MaxDesiatov As far as I understand, |
|
They aren't mutually exclusive, |
kateinoigakukun
force-pushed
the
share-static-html
branch
from
8bfaafb to
cd5bbae
Compare
carson-katri
previously approved these changes
Sep 23, 2020
MaxDesiatov
changed the title
MaxDesiatov
changed the title
HTML type in TokamakDOM
MaxDesiatov
previously approved these changes
Sep 23, 2020
|
@kateinoigakukun I've sent you an invitation to the Tokamak team, feel free to merge 🙂 |
kateinoigakukun
dismissed stale reviews from MaxDesiatov and carson-katri
via
d922d4c
MaxDesiatov
approved these changes
Sep 23, 2020
|
Please merge this PR 🙏 I don't have commit permission 🤔 |
|
Sorry about that, I've updated the permissions, feel free to merge and let me know if there are any problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTMLshould be available when targeting dynamic HTML. Without this symlink, we need to import onlyHTMLto avoid protocol conformance conflict.e.g. https://github.com/kateinoigakukun/swiftwasm-pad/blob/9dc42e0ac6c37f6a408fdf5cbd37358b5eebb070/Frontend/Sources/SwiftWasmPad/App.swift#L4