Fix memory leak when breaking mid-way in _get_objects and _get_ids #266
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a memory leak that is caused from resources not being freed when using
_get_objects
and_get_ids
and not consuming all of the items in the generator.Explanation - this is the way these functions are implemented currently:
When iterating the objects, but breaking mid way, the memory is not released:
If we use
finally
instead, it simplifies the code and ensures that memory is always released:This works when consuming the entire iterator:
And when breaking in the middle: