-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TLF should calculate points and multis on every start #248
Comments
Same problem exists for scoring multis. |
At least for the display it would make sense to keep the score/multi info in the log line. (the latter was missing in the screenshot in #247 as I bypassed the native multi handling) Whether to write the info back to the log (update the record) or just keep it in |
Hmm. The log line display reads the data from the file not from qsos[] (see |
I see. But if qsos[] holds the same data (minus recalculated fields) as the log file, then it could be used to get the lines. |
Right. I am just looking to make sure it has no side effects so that we do not break something different. |
Some further thoughts:
Both points - changed log file and dependency on a complete set of related files - is a serious change of TLFs behavior and usage. Such a change is normally related to a major version change to TLF-2.x and should not done |
As soon as we calculate points and multis on every start writing them in the log file makes no longer sense. - agree, but I'm not afraid this can makes any problem. Just write back the correct points and multis to logfile. To make a backup during the re-score event can avoid the data loss. |
Let me add some more aspects:
I think this is not much loss.
|
I can see your points, but what I learned in the last years with TLF is that there are quite a lot of people with quite a lot of different working styles out there. So their mileage may vary. At least we should make clear that TLF will behave seriously different than before. |
Shall we postpone this after the next release? |
I would at least not make it a blocker. Looking deeper into it there are quite some related problems which should not be solved in haste. |
Meantime I figured out something: we should introduce a new CLI option, and if user starts It needs an explicit user interaction so I assume user knows what she/he does, eg. he/she makes a backup before... Any idea? |
This is a first part to fix issue #248. Besides some cleanup, simplification and restructuring it changes addcall() to accept a qso_t record of relevant information. That gets collected by a new function collect_qso_data() from the bunch of global variables. Long term goal is to use the same addcall() function for evaluation of newly made QSOs and of contacts red from the log file during readcalls(). Furthermore the patch uses parse_qso() to get these information from QSOs coming in from LAN (in addcall2() ) or from reading the already written log file (in readcalls() ). * readcalls() should remember any worked station even if excluded for scoring * Add function to update worked station for last qso and to collect qso data into struct qso_t * Collect qso data into struct qso_t and give it addcall() as parameter * extend parsing of QSO record and use parse_qso() for addcall2() and readcalls() * Simplify country and zone scoring. Score also on non-contest bands. That values will be ignored during display of contest results. * Simplify checkexchange() - drop refresh of comment display as it gets not changed by the function. Furthermore drop the no longer needed control parameter and hand over string to check as parameter
On restart with an existing not empty logfile TLF does not calculate points according to the actual contest rules but just reads them from what was recorded in the logfile in former runs (see discussion in Issue #178).
The text was updated successfully, but these errors were encountered: