Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send smsCodeMatcher for getSmsCode #94

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Conversation

andrelmlins
Copy link
Contributor

Hi guys, great project. I verified that the 'smsCodeMatcher' was not being sent and made the correction.

@Tkko
Copy link
Owner

Tkko commented Jun 14, 2022

Hi @andrelmlins thanks for the PR
Just one more thing, could you also make smsCodeMatcher non nullable as SmartAuth doesn't accept nullable matcher

final String? smsCodeMatcher;

@andrelmlins
Copy link
Contributor Author

Hi @Tkko , change made

@Tkko Tkko merged commit fce424e into Tkko:master Jun 14, 2022
@andrelmlins
Copy link
Contributor Author

@Tkko would it be possible to generate a new version today?

@Tkko
Copy link
Owner

Tkko commented Jun 14, 2022

On it 🫡

@Tkko
Copy link
Owner

Tkko commented Jun 14, 2022

@andrelmlins version 2.2.11 is uploaded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants