Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add load and loads to type stubs #116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add load and loads to type stubs #116

wants to merge 1 commit into from
+2 −0

Conversation

mdboom
Copy link

@mdboom mdboom commented Jun 13, 2024

The load and loads methods aren't included in the typestubs, so pyright complains when users use them:

foo.py:45:28 - error: "load" is not a known member of module "simdjson" (reportAttributeAccessIssue)

@mdboom
Add load and loads to type stubs
78e2a33 
The load and loads methods aren't included in the typestubs, so pyright complains when users use them:

```
foo.py:45:28 - error: "load" is not a known member of module "simdjson" (reportAttributeAccessIssue)
```
@TkTech
Copy link
Owner

TkTech commented Jun 19, 2024

Thanks! But json.load and json.loads aren't used for the pysimdjson.load and pysimdjson.loads, they have different signatures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdboom @TkTech