Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all selectors from 'CSS selector' to (By.CSS_SELECTOR, 'CSS selector') in constacts.py and waobject.py #51

Closed
NavpreetDevpuri opened this issue Oct 19, 2020 · 2 comments · Fixed by #65
Closed

Replace all selectors from 'CSS selector' to (By.CSS_SELECTOR, 'CSS selector') in constacts.py and waobject.py #51

NavpreetDevpuri opened this issue Oct 19, 2020 · 2 comments · Fixed by #65
Assignees
@pyvelkov
Labels
good first issue Good for newcomers python

Comments

@NavpreetDevpuri
Copy link
Member

For example

# from 
MAIN_SEARCH_BAR = '._3FRCZ'
EC.presence_of_element_located((By.CSS_SELECTOR, selector))
relement = element.find_element(By.CSS_SELECTOR, selector)

# to 
MAIN_SEARCH_BAR = (By.CSS_SELECTOR, '._3FRCZ')
EC.presence_of_element_located(selector)
relement = element.find_element(selector[0], selector[1])
@pyvelkov
Copy link
Contributor

hey, can I take a crack at this?

@NavpreetDevpuri
Copy link
Member Author

@pyvelkov
good luck!

@pyvelkov pyvelkov mentioned this issue Oct 23, 2020
Merged
@NavpreetDevpuri NavpreetDevpuri linked a pull request Oct 24, 2020 that will close this issue
Replaced all selectors from 'CSS selector' to (By.CSS_SELECTOR, 'CSS selector') in constacts.py and waobject.py #51 #65
Merged
NavpreetDevpuri added a commit that referenced this issue Oct 24, 2020
@NavpreetDevpuri
Merge pull request #65 from pyvelkov/main
617237d 
Replaced all selectors from 'CSS selector' to (By.CSS_SELECTOR, 'CSS selector') in constacts.py and waobject.py #51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pyvelkov pyvelkov

Labels
good first issue Good for newcomers python
Projects
None yet
Milestone
No milestone
2 participants
@NavpreetDevpuri @pyvelkov