Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved docs related to the private key #20

Merged
merged 2 commits into from
May 24, 2024

Conversation

omarzl
Copy link
Contributor

@omarzl omarzl commented May 23, 2024

I struggled a little bit understanding what I should use in the arg --private-key-path while creating a provisioning profile
I am used to let Keychain Assistant to create the key pair and the CSR 😄

So this pr aims to improve the docs regarding the priv key. Do you consider it is the right place to include this command example?

Also are you using the same command openssl genrsa -out key.pem 2048? Or do you suggest another one.

Thanks!

Copy link
Collaborator

@tinder-maxwellelliott tinder-maxwellelliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@tinder-maxwellelliott tinder-maxwellelliott merged commit 8f3bd6c into Tinder:main May 24, 2024
4 checks passed
@omarzl
Copy link
Contributor Author

omarzl commented May 31, 2024

For the record, I just noticed that Keychain Assistant let you customize the key pair, and the default value is an RSA 2048 key 👍🏼

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants