Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix ad copy input text name and add button props to state #151

Conversation

thinkjrs
Copy link
Member

This adds a few missing props and fixes along those lines so that state are updated more efficiently/correctly.

In addition, it adds typing for the Button submission function, which we will eventually extract so that clients can customize this functionality.

@thinkjrs thinkjrs self-assigned this Apr 20, 2023
@github-actions
Copy link

size-limit report 📦

Path Size
dist/promo-button.cjs.production.min.js 96.36 KB (+0.08% 🔺)
dist/promo-button.esm.js 81.4 KB (+0.1% 🔺)

@thinkjrs thinkjrs merged commit ffe865d into develop Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant