Multiple once calls cancel each other

[TimoBechtel]

what it does

When once is called multiple times with the same path, the first one that receives an update will unsubscribe the path and therefore the second one is never called.

db.get('path').once(() => {
  // receives update and unsubscribes from path
});
db.get('path').once(() => {
  // never receives update
})

db.get('path').set('test');

Issue is basically this line:

socketdb/src/client.ts

Line 274 in 8f8e601

unsubscribe(path, listener);

what it should do

All once listener should be called when an update arrives.

[TimoBechtel]

Now, this took me a while to figure out, but the issue comes down to this:

For some reason I chose to use Array.splice to remove listeners.
This was a really bad idea. Because now, if someone unsubscribes from a path while an iteration over all listeners is in progress, the iteration does behave weirdly, as splice will remove items in place. Therefore skipping the last once in the example above.

Replacing splice with a simple Array.filter should be enough to fix the issue.

[github-actions]

🎉 This issue has been resolved in version 3.6.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀