dogsdogsdogs/lookup_map: Add unsafe variant #337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
|
We probably don't want this, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an unsafe variant of the
lookup_mapoperator in the spirit of #326.The implementation relies on two function, where one consumes the output of
map_timesand the other one produces actual stream data. I'm not particularly happy about this design because it makes it cumbersome to share data between the two functions, but it seems to do the job.Alternatives include passing an explicit shared piece of data to the functions, or provide direct access to the cursor and storage.
Signed-off-by: Moritz Hoffmann antiguru@gmail.com