Dismiss or pop view controllers accordingly #443
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Tim!
Got caught up with Assassin's Creed Valhalla release yesterday! So sorry! I can't help it!
Anyway, here is my PR for improving the dismissing of the view controller in your default done and cancel handler.
I added a check to see if the view controller is embedded in a navigation controller. If it is the root of the navigation controller, dismiss the navigation controller. If it is not, then just pop the view controller.
If the view controller is presented modally without being embedded in a navigation controller, then just dismiss the view controller accordingly.
Note:
I see you have this on line 894:
I took the liberty of deleting this line because I am not sure why this is in the cancel handler but not in the done handler.
Please let me know if you still want this behavior. And maybe if you want to standardise it for both cancel and done.