Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makes delegate weak instead strong reference at CropViewController. #338

Merged
merged 1 commit into from
Apr 21, 2019
Merged

Makes delegate weak instead strong reference at CropViewController. #338

merged 1 commit into from
Apr 21, 2019

Conversation

Ikloo
Copy link
Contributor

@Ikloo Ikloo commented Mar 1, 2019

Hi!

I found issue with retain cycle in the pod.
It's strong delegate property at CropViewController class.
Changed to weak reference.

@Ikloo Ikloo changed the title Make delegate weak instead strong reference at CropViewController. Makes delegate weak instead strong reference at CropViewController. Mar 1, 2019
@TimOliver
Copy link
Owner

Ah! Well spotted! Thank you!

@TimOliver TimOliver merged commit d4e786d into TimOliver:master Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ikloo @TimOliver