Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Version 3.0 #25

Merged
merged 23 commits into from
Jan 1, 2019
Merged

Release Version 3.0 #25

merged 23 commits into from
Jan 1, 2019

Conversation

TimNN
Copy link
Owner

@TimNN TimNN commented Dec 31, 2018

This (currently WIP) PR is a complete reimplementation of cargo-lipo (what 2.0 should have been originally).

The main new features are:

  • Reimplementation following current best-practices, including a switch to the 2018 edition.
  • Use cargo_metadata to understand the project rather than some custom logic.
  • Automatically remove environment variables that can cause issues with build scripts.
  • Simplify integration with XCode build scripts: Automatically discover targets and profile from the environment.

This PR is still missing some tests (the basic functionality was manually tested, the XCode integration not at all).

Todo:

  • Add tests for:
    • Building a simple project
    • Building a workspace with multiple packages, only some of which are staticlibs
    • Building only specific packages in a workspace
    • Building a package with a build script and dependencies with build scripts
  • Improve CI:
    • Run & enforce no-warnings clippy
    • Run & enforce no-diff rustfmt
  • Improve Readme.md:
    • Document important options
    • Document XCode integration

Fixes #22.

@eoger
Copy link
Contributor

eoger commented Jan 1, 2019

Automatically remove environment variables that can cause issues with build scripts.

Does this mean I can probably get rid of nenv uses?

@TimNN
Copy link
Owner Author

TimNN commented Jan 1, 2019

Automatically remove environment variables that can cause issues with build scripts.

Does this mean I can probably get rid of nenv uses?

Yes, once this PR is merged, this should mean exactly that!

@TimNN
Copy link
Owner Author

TimNN commented Jan 1, 2019

@eoger:

Does this mean I can probably get rid of nenv uses?

I've just published version 3.0, which has the sanitization logic. If you're still having issues, I would love to hear about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants