-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [sc-58279] [core] add tiledb_array_schema_get_enumeration
API
#5359
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left some small comments, looks great so far 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from me. @ypatia already suggested the REST test which is all I had thought of.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 👍
Story details: https://app.shortcut.com/tiledb-inc/story/58279
This pull request implements the above and adds unit tests which demonstrate that
tiledb_array_schema_get_enumeration
abides by the above:This pull request does not attempt to bridge the gap between 2 and 3, i.e. load the enumeration when it is requested.
TYPE: FEATURE | C_API | CPP_API
DESC: add tiledb_array_schema_get_enumeration