Restore visibility of tiledb_ctx_alloc_with_error.
#5357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will validate that the symbol exists.
teo-tsirpanis
force-pushed
the
teo/ctx-alloc-with-error
branch
from
a1fe79b to
f3082ab
Compare
teo-tsirpanis
commented
Oct 23, 2024
ihnorton
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-58150
Starting with #3524 due to an oversight, the
tiledb_ctx_alloc_with_errorfunction could not be used because the symbol was not publicly visible. This PR fixes this and conforms the implementation of the API to match the other APIs.Validated by adding a usage of
tiledb_ctx_alloc_with_errorto an example (which links dynamically to libtiledb).TYPE: BUG
DESC: Fixed the
tiledb_ctx_alloc_with_errorfunction not being exported from the library.