Re-enable TILEDB_CCACHE support.
#5342
Merged
+12
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teo-tsirpanis
force-pushed
the
teo/ccache
branch
from
1e14deb to
4e4c24b
Compare
CMake recommends against setting them manually.
pjonsson
reviewed
Oct 9, 2024
ihnorton
reviewed
Oct 9, 2024
| # without this compiler messages in `make` backend would be uncolored | ||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fdiagnostics-color=auto") | ||
| endif() | ||
| set_property(GLOBAL PROPERTY RULE_LAUNCH_COMPILE ${CCACHE_FOUND}) |
There was a problem hiding this comment.
There was a problem hiding this comment.
I don't know anything about Windows and how building works there, but https://cmake.org/cmake/help/latest/prop_gbl/RULE_LAUNCH_COMPILE.html makes it clear that RULE_LAUNCH_COMPILE is internal.
And the commit message of llvm/llvm-project@0fad18c seems to indicate CMake 3.4 should be enough, the commit was reverted in llvm/llvm-project@fff762d because the build bots needed to be updated first.
There was a problem hiding this comment.
It's likely setting these properties caused compile errors. They used to be applied only on the superbuild so they were not actually being used before.
dudoslav
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-57386
Fixes #5341 and simplifies
FindCcache.cmake. Validated locally.TYPE: BUILD
DESC: The
TILEDB_CCACHEoption was fixed to have effect, after being accidentally disabled in version 2.26.0.