Support cross-compiling in the libmagic vcpkg port overlay. #5333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jdblischak can we run Conda nightly builds on this branch for further validation? |
Yes, I'll set up a build now |
|
Nightlies succeeded. Thanks @jdblischak! |
ihnorton
approved these changes
Oct 3, 2024
teo-tsirpanis
added a commit
to teo-tsirpanis/TileDB
that referenced
this pull request
Oct 9, 2024
…ileDB-Inc#5333)" This reverts commit f47efff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes TileDB-Inc/conda-forge-nightly-controller#145.
This PR adds support for cross-compiling our custom vcpkg port overlay for libmagic. This is accomplished by installing libmagic as a host dependency, and using the host's
file.exeto buildmagic.mgcin cross-compiled builds.Validated locally by successfully cross compiling the Core for Windows-ARM64 (with cloud storage and serialization disabled because these dependencies are not yet compatible).
TYPE: BUILD
DESC: Fixed cross-compiling support in the libmagic vcpkg port overlay.