fix: [sc-56713] [core] query returns incorrect offsets for dense array fill value of variable-length int32 attribute #5331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story details: https://app.shortcut.com/tiledb-inc/story/56713
tiledb-rs
uses the settingsm.var_offsets.mode = elements
and the dense reader code which copies the fill value offsets does not check this setting.This pull request fixes the issue by checking whether that value was previously set; and adds unit tests demonstrating correct fill value offsets in three different scenarios.
TYPE: BUG
DESC: Fix dense reader fill value with
sm.var_offsets.mode = elements