Let the AWS SDK determine the default region. #5317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvigilante
approved these changes
Sep 23, 2024
ihnorton
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-55556
While the S3 VFS' default AWS region is always
us-east-1, the AWS SDK uses a sequence of multiple sources to determine the default region. This PR lets the AWS SDK pick a region if the user has not chosen one with thevfs.s3.regionoption, improving the experience when on regions other thanus-east-1.This was implemented by updating the default value of
vfs.s3.regionto empty. There is already logic to keep using the AWS SDK's default if the config option is empty.TYPE: CONFIG
DESC: The default value of
vfs.s3.regionwas changed to empty, which will let the AWS pick the default region from sources such as environment variables, profile configuration, and instance metadata.