Use a constant suffix for temporary GCS part files. #5308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiterLuc
approved these changes
Sep 17, 2024
ihnorton
pushed a commit
that referenced
this pull request
Nov 15, 2024
[SC-59383](https://app.shortcut.com/tiledb-inc/story/59383/update-temporary-file-suffix-to-tiledb-tmp) This PR updates the extension of temporary files from `.tmp` (first introduced in #5308) to `.tiledb.tmp`, enabling users to take action specifically to temporary files produced by TileDB. --- TYPE: IMPROVEMENT DESC: Temporary files (currently used by GCS only) now end with `.tiledb.tmp`, allowing you to set a lifecycle rule to automatically delete them after a set amount of time if they happen to be left over.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-54146
This PR changes the format of the names of temporary GCS part files from
<object_path>__tiledb_<n>to<object_path>.part<n>.tmp. Because the new names have a constant.tmpsuffix, this enables GCS users to set a lifecycle rule to automatically delete them after a certain time if they happen to be left over (usually they get deleted at the end of the upload operation, but it might not happen if the operation was interrupted).Documentation will also be updated. For consistency we should also use
.tmpfor any kind of future temporary objects we upload.TYPE: IMPROVEMENT
DESC: Temporary files (currently used by GCS only) now end with
.tmp, allowing you to set a lifecycle rule to automatically delete them after a certain time if they happen to be left over.