Enable curl error retries. #5273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to release-2.26 |
|
Started backporting to release-2.26: https://github.com/TileDB-Inc/TileDB/actions/runs/10684663732 |
nickvigilante
approved these changes
Sep 3, 2024
ypatia
force-pushed
the
yt/sc-54277/enable_curl_error_retries
branch
from
42a2335 to
25393b8
Compare
ypatia
force-pushed
the
yt/sc-54277/enable_curl_error_retries
branch
from
78ed593 to
d43b024
Compare
Co-authored-by: Shaun M Reed <shaunrd0@gmail.com>
ypatia
force-pushed
the
yt/sc-54277/enable_curl_error_retries
branch
from
d43b024 to
75a07f5
Compare
KiterLuc
pushed a commit
that referenced
this pull request
Sep 4, 2024
|
I think we should backpot this to 2.27 as well. |
|
@teo-tsirpanis we might have to but we might get rid of the current release-2.27 branch so let's not do it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core-side retries on curl errors have been explicitly disallowed in the past in #3712 to protect from double writes in case of errors in a connection teardown phase, so after a fragment has been written, where a retry would just re-write the same fragment.
However, we have experienced spurious "Connection reset by peer" type of errors especially during ingestion (Write queries), which we think could be mitigating by allowing retries for most of curl errors. (exclude those that typically happen during connection teardown).
[sc-54377]
TYPE: IMPROVEMENT
DESC: Enable curl error retries.