Bug fix: update range end when merging overlapping subarray ranges. #5268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the change is the right one. Aside from fixing the current tests, we should add tests that mimic the regression test in: "RangeSetAndSuperset::sort_and_merge_ranges - numeric", |
davisp
reviewed
Aug 28, 2024
KiterLuc
approved these changes
Sep 2, 2024
|
@bekadavis9 let's describe the bug in more details in the PR description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: update range end when merging overlapping subarray ranges.
Previously, when merging overlapping ranges, the new range end would always be updated to that of the merged range. This was a clear issue if one range was fully encompassed within another. For example, if range
{3, 4}were merged into{1, 10}, the old behavior would produce a new range of{1, 4}. This PR fixes the bug simply, taking the larger of the two range ends on merge.[sc-53970]
TYPE: BUG
DESC: Update range end when merging overlapping subarray ranges.