Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tiledb_fragment_info_dump_str C API and replace FragmentInfo::dump(FILE*) with operator<< overload. #5266

Merged
merged 4 commits into from
Sep 2, 2024
Merged

Add tiledb_fragment_info_dump_str C API and replace FragmentInfo::dump(FILE*) with operator<< overload. #5266

merged 4 commits into from
Sep 2, 2024

Conversation

kounelisagis
Copy link
Member

@kounelisagis kounelisagis commented Aug 28, 2024 •
edited by KiterLuc
Loading

After #5026, the only dump API that remains without a string counterpart is on FragmentInfo. This PR adds the tiledb_fragment_info_dump_str C API and replaces FragmentInfo::dump(FILE*) with an operator<< overload.

[sc-50605]

TYPE: C_API | CPP_API
DESC: Add tiledb_fragment_info_dump_str C API and replace FragmentInfo::dump(FILE*) with operator<< overload.

@kounelisagis kounelisagis marked this pull request as ready for review August 28, 2024 22:45
teo-tsirpanis
teo-tsirpanis reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@teo-tsirpanis teo-tsirpanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Looks mostly good to me.

tiledb/sm/fragment/single_fragment_info.h Outdated Show resolved Hide resolved
@kounelisagis @teo-tsirpanis
Add ensure_output_pointer_is_valid
bc12c76 
Co-authored-by: Theodore Tsirpanis <theodore.tsirpanis@tiledb.com>
teo-tsirpanis
teo-tsirpanis approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@teo-tsirpanis teo-tsirpanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@KiterLuc KiterLuc merged commit 097f155 into dev Sep 2, 2024
64 checks passed
@KiterLuc KiterLuc deleted the agis/add-tiledb-fragment-info-dump-str-c-api branch September 2, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teo-tsirpanis teo-tsirpanis teo-tsirpanis approved these changes

@eric-hughes-tiledb eric-hughes-tiledb Awaiting requested review from eric-hughes-tiledb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kounelisagis @teo-tsirpanis @KiterLuc