Prevent consolidation with fragment list in dense arrays if it could result in data loss. #5251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisStaratzis
force-pushed
the
dstara/sc-50064/disallow-dense-fragment-list-consolidation
branch
2 times, most recently
from
5e182e4 to
8d49155
Compare
KiterLuc
reviewed
Aug 23, 2024
KiterLuc
reviewed
Aug 28, 2024
DimitrisStaratzis
changed the title
DimitrisStaratzis
force-pushed
the
dstara/sc-50064/disallow-dense-fragment-list-consolidation
branch
from
efce830 to
e0a4714
Compare
KiterLuc
reviewed
Sep 6, 2024
| // cheaper. We compare the current fragment's start timestamp against the | ||
| // upper bound we calculated previously. | ||
| auto timestamp_range{frag_info.timestamp_range()}; | ||
| bool timestamp_before = !(timestamp_range.first > max_timestamp); |
There was a problem hiding this comment.
Suggested change
| bool timestamp_before = !(timestamp_range.first > max_timestamp); | |
| bool timestamps_overlap = !(timestamp_range.first > max_timestamp); |
KiterLuc
approved these changes
Sep 9, 2024
KiterLuc
changed the title
KiterLuc
deleted the
dstara/sc-50064/disallow-dense-fragment-list-consolidation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using fragment list consolidation with dense arrays, there is a possibility that consolidating some fragments would lead to data loss (see https://docs.tiledb.com/main/background/internal-mechanics/consolidation#algorithm for more details). This PR fixes this issue.
TYPE: IMPROVEMENT
DESC: Prevent consolidation with fragment list in dense arrays if it could result in data loss.