-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support setting S3 storage class. #5053
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teo-tsirpanis
commented
Jun 6, 2024
teo-tsirpanis
force-pushed
the
teo/s3-storage-class
branch
2 times, most recently
from
June 10, 2024 12:59
ce304a3
to
4317a48
Compare
KiterLuc
reviewed
Jun 10, 2024
DimitrisStaratzis
approved these changes
Jun 10, 2024
We need AWS SDK version 1.11.275 to skip the check in our code, and we are on 215.
teo-tsirpanis
force-pushed
the
teo/s3-storage-class
branch
from
June 10, 2024 18:39
924285a
to
1a1712e
Compare
CI is green, apart from the Windows failures. |
KiterLuc
added a commit
that referenced
this pull request
Jun 11, 2024
[SC-48305](https://app.shortcut.com/tiledb-inc/story/48305) [SC-48552](https://app.shortcut.com/tiledb-inc/story/48552/arrays-support-s3-storage-classes) This PR adds a config option to support setting the storage class of the objects that get uploaded to S3. This allows users to seamlessly take advantage of features like [Amazon S3 Intelligent-Tiering](https://aws.amazon.com/s3/storage-classes/intelligent-tiering/). --- TYPE: CONFIG DESC: Add `vfs.s3.storage_class` config option to set the storage class of newly uploaded S3 objects. --------- Co-authored-by: KiterLuc <67824247+KiterLuc@users.noreply.github.com>
KiterLuc
added a commit
that referenced
this pull request
Jun 11, 2024
[SC-48305](https://app.shortcut.com/tiledb-inc/story/48305) [SC-48552](https://app.shortcut.com/tiledb-inc/story/48552/arrays-support-s3-storage-classes) This PR adds a config option to support setting the storage class of the objects that get uploaded to S3. This allows users to seamlessly take advantage of features like [Amazon S3 Intelligent-Tiering](https://aws.amazon.com/s3/storage-classes/intelligent-tiering/). --- TYPE: CONFIG DESC: Add `vfs.s3.storage_class` config option to set the storage class of newly uploaded S3 objects. --------- Co-authored-by: KiterLuc <67824247+KiterLuc@users.noreply.github.com>
KiterLuc
added a commit
that referenced
this pull request
Jun 11, 2024
KiterLuc
added a commit
that referenced
this pull request
Jun 19, 2024
[SC-48305](https://app.shortcut.com/tiledb-inc/story/48305) [SC-48552](https://app.shortcut.com/tiledb-inc/story/48552/arrays-support-s3-storage-classes) This PR adds a config option to support setting the storage class of the objects that get uploaded to S3. This allows users to seamlessly take advantage of features like [Amazon S3 Intelligent-Tiering](https://aws.amazon.com/s3/storage-classes/intelligent-tiering/). --- TYPE: CONFIG DESC: Add `vfs.s3.storage_class` config option to set the storage class of newly uploaded S3 objects. --------- Co-authored-by: KiterLuc <67824247+KiterLuc@users.noreply.github.com>
KiterLuc
added a commit
that referenced
this pull request
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-48305
SC-48552
This PR adds a config option to support setting the storage class of the objects that get uploaded to S3. This allows users to seamlessly take advantage of features like Amazon S3 Intelligent-Tiering.
TYPE: CONFIG
DESC: Add
vfs.s3.storage_class
config option to set the storage class of newly uploaded S3 objects.