Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOT FOR MERGE] Bring object library generic_tile_io into conformance with standalone link policy #4972

Closed
wants to merge 4 commits into from

Conversation

eric-hughes-tiledb
Copy link
Contributor

PR #4051 took object library generic_tile_io out of conformance with the policy that each OL should link standalone. This PR corrects this.

Note: In its present state this PR is not suitable for review or merge. It's branched from a branch that itself has not merged yet and needs to be rebased before review is feasible.


TYPE: NO_HISTORY
DESC: [NOT FOR MERGE] Bring object library generic_tile_io into conformance with standalone link policy

Update object library and unit tests within the `c_api` directory tree to use CMake environments. This replaces direct calls to `add_library`, `add_executable`, and `add_test`.
* `array`, `buffer`, `buffer_list`, `config`, `context`, `data_order`, `datatype`, `dimension_label`, `filesystem`, `filter`, `filter_list`, `query_aggregate`, `query_plan`, `query_type`, `vfs`

A small number of object library declarations were not converted. These were only those that cannot currently be linked standalone. The documentation of these remaining one was tightened up.
Add documentation that the underlying `query_plan` object library does not link standalone.
…ce with standalone link policy

PR #4051 took object library `generic_tile_io` out of conformance with the policy that each OL should link standalone. This PR corrects this.

Note: In its present state this PR is not suitable for review or merge. It's branched from a branch that itself has not merged yet and needs to be rebased before review is feasible.
@eric-hughes-tiledb
Copy link
Contributor Author

Closed in favor of #4975, which is not on a work-in-progress branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant