Pass AWS client config when creating STSAssumeRoleCredentialsProvider.
#4616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Getting a PR ready so that we can get a build faster if we confirm the fix. |
KiterLuc
changed the title
STSAssumeRoleCredentialsProvider.STSAssumeRoleCredentialsProvider.
ihnorton
approved these changes
Jan 12, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jan 12, 2024
…r`. (#4616) This fixes an issue with assume role where the client configuration was not getting passed to the `STSAssumeRoleCredentialsProvider`, which resulted in options like the CA path not being honored when the AWS SDK was making HTTP requests for assume role. --- TYPE: BUG DESC: Fix HTTP requests for AWS assume role not honoring config options. Co-authored-by: Theodore Tsirpanis <theodore.tsirpanis@tiledb.com> (cherry picked from commit 6b29117)
github-actions bot
pushed a commit
that referenced
this pull request
Jan 12, 2024
…r`. (#4616) This fixes an issue with assume role where the client configuration was not getting passed to the `STSAssumeRoleCredentialsProvider`, which resulted in options like the CA path not being honored when the AWS SDK was making HTTP requests for assume role. --- TYPE: BUG DESC: Fix HTTP requests for AWS assume role not honoring config options. Co-authored-by: Theodore Tsirpanis <theodore.tsirpanis@tiledb.com> (cherry picked from commit 6b29117)
KiterLuc
pushed a commit
that referenced
this pull request
Jan 17, 2024
…sProvider`. (#4641) This PR applies a similar fix to #4616 but for `STSProfileWithWebIdentityCredentialsProvider`. That class was also adjusted to prevent a memory leak, to use the user-provided `STSClient` if available, and to use public APIs. The issue has been validated to be fixed. --- TYPE: BUG DESC: Fix HTTP requests for AWS assume role with web identity not honoring config options.
github-actions bot
pushed a commit
that referenced
this pull request
Jan 17, 2024
…sProvider`. (#4641) This PR applies a similar fix to #4616 but for `STSProfileWithWebIdentityCredentialsProvider`. That class was also adjusted to prevent a memory leak, to use the user-provided `STSClient` if available, and to use public APIs. The issue has been validated to be fixed. --- TYPE: BUG DESC: Fix HTTP requests for AWS assume role with web identity not honoring config options. (cherry picked from commit 4498063)
github-actions bot
pushed a commit
that referenced
this pull request
Jan 17, 2024
…sProvider`. (#4641) This PR applies a similar fix to #4616 but for `STSProfileWithWebIdentityCredentialsProvider`. That class was also adjusted to prevent a memory leak, to use the user-provided `STSClient` if available, and to use public APIs. The issue has been validated to be fixed. --- TYPE: BUG DESC: Fix HTTP requests for AWS assume role with web identity not honoring config options. (cherry picked from commit 4498063)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with assume role where the client configuration was not getting passed to the
STSAssumeRoleCredentialsProvider, which resulted in options like the CA path not being honored when the AWS SDK was making HTTP requests for assume role.TYPE: BUG
DESC: Fix HTTP requests for AWS assume role not honoring config options.