Fix out of order consolidation. #4597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following issue TileDB-Inc/TileDB-Py#1885 reported that running consolidation in this order invalidates an array: - consolidate fragments - consolidate commits - vacuum fragments - vacuum commits This fixes two issues: - We sometimes would not delete the commit files when vacuuming fragments. - We would vacuum an ignore file when a consolidated commits file still needed it. --- TYPE: BUG DESC: Fix out of order consolidation.
|
This pull request has been linked to Shortcut Story #38672: Consolidation order can create a corrupted array. |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 19, 2024
The following issue TileDB-Inc/TileDB-Py#1885 reported that running consolidation in this order invalidates an array: - consolidate fragments - consolidate commits - vacuum fragments - vacuum commits This fixes two issues: - We sometimes would not delete the commit files when vacuuming fragments. - We would vacuum an ignore file when a consolidated commits file still needed it. --- TYPE: BUG DESC: Fix out of order consolidation. (cherry picked from commit 65d1ce4)
Shelnutt2
pushed a commit
that referenced
this pull request
Apr 22, 2024
The following issue TileDB-Inc/TileDB-Py#1885 reported that running consolidation in this order invalidates an array: - consolidate fragments - consolidate commits - vacuum fragments - vacuum commits This fixes two issues: - We sometimes would not delete the commit files when vacuuming fragments. - We would vacuum an ignore file when a consolidated commits file still needed it. --- TYPE: BUG DESC: Fix out of order consolidation. (cherry picked from commit 65d1ce4)
Shelnutt2
pushed a commit
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following issue TileDB-Inc/TileDB-Py#1885 reported that running consolidation in this order invalidates an array:
This fixes two issues:
TYPE: BUG
DESC: Fix out of order consolidation.