Don't segfault in ArraySchema::dump #4583
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no check for whether an enumeration was loaded before attempting to dump it during a call to ArraySchema::dump. Obviously, dereferencing nullptr is bad so this avoids doing that.
The new output now shows the following when a Enumeration isn't loaded:
And after calling
load_all_enumerations
:TYPE: BUG
DESC: Don't segfault in ArraySchema::dump