Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix delta filter deserialization for format ver 19. #4541

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Fix delta filter deserialization for format ver 19. #4541

merged 1 commit into from
Nov 27, 2023

Conversation

KiterLuc
Copy link
Contributor

This fixes the delta filter deserialization for version 19. In that version, we already included the extra reinterpret type.

TYPE: BUG
DESC: Fix delta filter deserialization for format ver 19.

@KiterLuc
Fix delta filter deserialization for format ver 19.
f5db0ee 
This fixes the delta filter deserialization for version 19. In that version, we already included the extra reinterpret type.

---
TYPE: BUG
DESC: Fix delta filter deserialization for format ver 19.
johnkerl
johnkerl approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in sandbox; details in [sc-37622]

@KiterLuc
Copy link
Contributor Author

Added https://app.shortcut.com/tiledb-inc/story/37624/add-tests-for-version-19-delta-filter-deserialization as a follow up.

@KiterLuc KiterLuc merged commit 2b1ada7 into dev Nov 27, 2023
62 checks passed
@KiterLuc KiterLuc deleted the lr/delta-ver19-reinterpret-type branch November 27, 2023 21:54
@github-actions github-actions bot mentioned this pull request Nov 27, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Nov 27, 2023
@KiterLuc @github-actions
Fix delta filter deserialization for format ver 19. (#4541)
30ee994 
This fixes the delta filter deserialization for version 19. In that
version, we already included the extra reinterpret type.

---
TYPE: BUG
DESC: Fix delta filter deserialization for format ver 19.

(cherry picked from commit 2b1ada7)
KiterLuc added a commit that referenced this pull request Nov 28, 2023
@github-actions @KiterLuc
[Backport release-2.18] Fix delta filter deserialization for format v…
959ce43 
…er 19. (#4542)

Backport 2b1ada7 from #4541.

Co-authored-by: KiterLuc <67824247+KiterLuc@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Nov 28, 2023
@KiterLuc @github-actions
Fix delta filter deserialization for format ver 19. (#4541)
2aa84af 
This fixes the delta filter deserialization for version 19. In that
version, we already included the extra reinterpret type.

---
TYPE: BUG
DESC: Fix delta filter deserialization for format ver 19.

(cherry picked from commit 2b1ada7)
@github-actions github-actions bot mentioned this pull request Nov 28, 2023
Merged
KiterLuc added a commit that referenced this pull request Nov 28, 2023
@github-actions @KiterLuc
[Backport release-2.17] Fix delta filter deserialization for format v…
bd8d226 
…er 19. (#4544)

Backport 2b1ada7 from #4541.

Co-authored-by: KiterLuc <67824247+KiterLuc@users.noreply.github.com>
@teo-tsirpanis teo-tsirpanis mentioned this pull request Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnkerl johnkerl johnkerl approved these changes

Assignees
No one assigned
Labels
backport release-2.17 backport release-2.18
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KiterLuc @johnkerl