Revert change to S3 is_object, is_bucket checks #4370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #34450: Revert S3.cc logic change for is_object and is_bucket. |
The is_bucket and is_object methods are now behaving different in 2.17 and returning errors when they wouldn't previously. For now we're reverting to the previous 2.16 behavior.
davisp
force-pushed
the
pd/sc-34450/revert-bad-s3-change
branch
from
2f8dfe7
to
7d19ed7
Compare
ihnorton
approved these changes
Sep 19, 2023
ihnorton
changed the title
ihnorton
pushed a commit
that referenced
this pull request
Sep 20, 2023
The is_bucket and is_object methods are now behaving different in 2.17 and returning errors when they wouldn't previously. For now we're reverting to the previous 2.16 behavior. x-ref #4370 --- TYPE: BUG DESC: Revert change to S3 is_object, is_bucket checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The is_bucket and is_object methods are now behaving different in 2.17 and returning errors when they wouldn't previously. For now we're reverting to the previous 2.16 behavior.
TYPE: BUG
DESC: Revert change to S3 is_object, is_bucket checks.