Avoid empty HTTP requests to load Enumerations #4369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we weren't checking if we actually had any enumerations to load which resulted in REST requests for an empty list of enumerations. That just wastes time and resources for no reason so this change avoids the request whn there's no work to do.
davisp
force-pushed
the
pd/bug/avoid-empty-enumerations-requests
branch
from
adc29e8
to
200bd68
Compare
Shelnutt2
approved these changes
Sep 19, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Sep 22, 2023
Previously, we weren't checking if we actually had any enumerations to load which resulted in REST requests for an empty list of enumerations. That just wastes time and resources for no reason so this change avoids the request whn there's no work to do. --- TYPE: IMPROVEMENT DESC: Avoid empty Enumeration REST requests. (cherry picked from commit 7d17d10)
ihnorton
pushed a commit
that referenced
this pull request
Sep 22, 2023
Previously, we weren't checking if we actually had any enumerations to load which resulted in REST requests for an empty list of enumerations. That just wastes time and resources for no reason so this change avoids the request whn there's no work to do. --- TYPE: IMPROVEMENT DESC: Avoid empty Enumeration REST requests. (cherry picked from commit 7d17d10) Co-authored-by: Paul J. Davis <paul.davis@tiledb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we weren't checking if we actually had any enumerations to load which resulted in REST requests for an empty list of enumerations. That just wastes time and resources for no reason so this change avoids the request whn there's no work to do.
TYPE: IMPROVEMENT
DESC: Avoid empty Enumeration REST requests.