Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cppapi] Fix sc-34380: don't error out if DELETE symbol is defined #4365

Merged
merged 1 commit into from
Sep 19, 2023
Merged

[cppapi] Fix sc-34380: don't error out if DELETE symbol is defined #4365

merged 1 commit into from
Sep 19, 2023

Conversation

ihnorton
Copy link
Member

@ihnorton ihnorton commented Sep 19, 2023 •
edited
Loading

We can avoid conflicting with the DELETE symbol by creating it, using token-pasting.

TYPE: CPP_API
DESC: Don't error out if DELETE symbol is defined.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #34380: Don't expose DELETE error in public C++ API.

@ihnorton
[cppapi] Fix sc-34380: don't error out if DELETE symbol is defined
ddee727 
We can avoid conflicting with the DELETE symbol by creating it,
using token-pasting.
@ihnorton ihnorton force-pushed the ihn/sc-34380/dont-police-delete-symbol branch from 283e6b0 to ddee727 Compare September 19, 2023 12:48
@ihnorton ihnorton marked this pull request as ready for review September 19, 2023 12:51
eric-hughes-tiledb
eric-hughes-tiledb approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@eric-hughes-tiledb eric-hughes-tiledb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a hack on top of a hack, but it will work for now.

@ihnorton ihnorton merged commit 31687b6 into dev Sep 19, 2023
54 checks passed
@ihnorton ihnorton deleted the ihn/sc-34380/dont-police-delete-symbol branch September 19, 2023 18:35
@github-actions github-actions bot mentioned this pull request Sep 19, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Sep 19, 2023
@ihnorton @github-actions
[cppapi] Fix sc-34380: don't error out if DELETE symbol is defined (#…
feed9bb 
…4365)

We can avoid conflicting with the DELETE symbol by creating it, using token-pasting.

---
TYPE: CPP_API
DESC: Don't error out if DELETE symbol is defined.

(cherry picked from commit 31687b6)
ihnorton added a commit that referenced this pull request Sep 20, 2023
@github-actions @ihnorton
[cppapi] Fix sc-34380: don't error out if DELETE symbol is defined (#…
58733b4 
…4365) (#4372)

We can avoid conflicting with the DELETE symbol by creating it, using token-pasting.

---
TYPE: CPP_API
DESC: Don't error out if DELETE symbol is defined.

(cherry picked from commit 31687b6)

Co-authored-by: Isaiah Norton <ihnorton@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-hughes-tiledb eric-hughes-tiledb eric-hughes-tiledb approved these changes

@KiterLuc KiterLuc Awaiting requested review from KiterLuc

Assignees
No one assigned
Labels
backport release-2.17
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ihnorton @eric-hughes-tiledb