Skip to content

Commit

Permalink
Declare config option value constants in the header.
Browse files Browse the repository at this point in the history
  • Loading branch information
teo-tsirpanis committed Sep 27, 2024
1 parent 5808eeb commit 131e416
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tiledb/sm/config/config.cc
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ const std::string Config::REST_RETRY_DELAY_FACTOR = "1.25";
const std::string Config::REST_CURL_BUFFER_SIZE = "524288";
const std::string Config::REST_CAPNP_TRAVERSAL_LIMIT = "2147483648";
const std::string Config::REST_CURL_VERBOSE = "false";
const std::string REST_CURL_TCP_KEEPALIVE = "true";
const std::string Config::REST_CURL_TCP_KEEPALIVE = "true";
const std::string Config::REST_CURL_RETRY_ERRORS = "true";
const std::string Config::REST_LOAD_ENUMERATIONS_ON_ARRAY_OPEN = "false";
const std::string Config::REST_LOAD_METADATA_ON_ARRAY_OPEN = "true";
Expand Down Expand Up @@ -176,7 +176,7 @@ const std::string Config::VFS_FILE_POSIX_FILE_PERMISSIONS = "644";
const std::string Config::VFS_FILE_POSIX_DIRECTORY_PERMISSIONS = "755";
const std::string Config::VFS_READ_AHEAD_SIZE = "102400"; // 100KiB
const std::string Config::VFS_READ_AHEAD_CACHE_SIZE = "10485760"; // 10MiB;
const std::string VFS_LOG_OPERATIONS = "false";
const std::string Config::VFS_LOG_OPERATIONS = "false";
const std::string Config::VFS_READ_LOGGING_MODE = "";
const std::string Config::VFS_AZURE_STORAGE_ACCOUNT_NAME = "";
const std::string Config::VFS_AZURE_STORAGE_ACCOUNT_KEY = "";
Expand Down
6 changes: 6 additions & 0 deletions tiledb/sm/config/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,9 @@ class Config {
/** The default for Curl's verbose mode used by REST. */
static const std::string REST_CURL_VERBOSE;

/** Whether to use TCP keepalive when connecting to REST. */
static const std::string REST_CURL_TCP_KEEPALIVE;

/** If we should retry Curl errors in requests to REST. */
static const std::string REST_CURL_RETRY_ERRORS;

Expand Down Expand Up @@ -438,6 +441,9 @@ class Config {
/** The maximum size (in bytes) of the VFS read-ahead cache . */
static const std::string VFS_READ_AHEAD_CACHE_SIZE;

/** Whether to log individual VFS operations. */
static const std::string VFS_LOG_OPERATIONS;

/** The type of read logging to perform in the VFS. */
static const std::string VFS_READ_LOGGING_MODE;

Expand Down

0 comments on commit 131e416

Please sign in to comment.