Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer rely on now-deprecated dump() for fragment info #753

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

eddelbuettel
Copy link
Contributor

Core just deprecated dump() for fragment info so we now rely on the stringstream method instead (as we had already done for a few other dump() replacements).

No new code, no new tests.

Copy link
Collaborator

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@eddelbuettel
Copy link
Contributor Author

Also passes the inofficial test batter once the (otherwise updated weekly on its own schedule) 'dev' container is current.

@eddelbuettel eddelbuettel merged commit 81847b3 into master Sep 9, 2024
1 check passed
@eddelbuettel eddelbuettel deleted the de/sc-54697/fragement_info_strstream branch September 9, 2024 16:48
@eddelbuettel eddelbuettel mentioned this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants