Extend NDRectangle support #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddelbuettel
requested review from
ihnorton,
robertbindar,
awenocur,
mojaveazure and
KiterLuc
awenocur
approved these changes
Aug 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on two recent Core PRs and extends the NDRectangle API surface. It also retires the cached
datatypeslot.New tests have been added as well.
(Actions got caught in 2.25 or earlier compile gotcha I didn't see here under 2.26 as well as in a need to condition all new tests, as well as several of the examples, for current domain and ndrectangle on 2.26 or later due to the change in S4 representation now that we can drop the local cache for data type.)