Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ndrectangle setter and getter for float{32,64} #742

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Support ndrectangle setter and getter for float{32,64} #742

merged 2 commits into from
Jul 31, 2024

Conversation

eddelbuettel
Copy link
Contributor

This builds on #741 and adds support for float and double.

SC 52170

ihnorton
ihnorton approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@eddelbuettel eddelbuettel merged commit d6bda66 into master Jul 31, 2024
1 check passed
@eddelbuettel eddelbuettel deleted the de/sc-52170/ndr4floats branch July 31, 2024 20:29
@eddelbuettel eddelbuettel mentioned this pull request Sep 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihnorton ihnorton ihnorton approved these changes

@awenocur awenocur Awaiting requested review from awenocur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddelbuettel @ihnorton