Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install TileDB with the top-level install-tiledb target. #711

Merged
merged 2 commits into from
May 28, 2024
Merged

Install TileDB with the top-level install-tiledb target. #711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68ab5bd
Install TileDB with the top-level `install-tiledb` target.
teo-tsirpanis May 28, 2024
aba8b41
Address PR feedback.
teo-tsirpanis May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions local/installTileDB.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ fi
mkdir build
cd build
../tiledb-src/bootstrap --prefix=../tiledb-inst --enable-static-tiledb --force-build-all-deps
make -j 8
make -C tiledb install
make -j 8 install-tiledb
cd ..

if [ ! -f .keep_build_dirs ]; then
Expand Down
3 changes: 1 addition & 2 deletions tools/buildTileDB.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,7 @@ fi
mkdir build
cd build
../tiledb-src/bootstrap --force-build-all-deps --enable-s3 --enable-serialization --linkage=shared
make -j 2
make -C tiledb install
make -j 2 install-tiledb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is good. The script is actually not triggered all that often: CRAN builds get artifacts, and default development builds usually find TileDB in /usr/local

cd ..

## Install
Expand Down
3 changes: 1 addition & 2 deletions tools/ci/valgrind/buildTileDB.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,7 @@ mkdir build
cd build
export AWSSDK_ROOT_DIR=/usr
../bootstrap --prefix=/usr/local --enable-s3 --enable-serialization --linkage=shared
make -j 8
make -C tiledb install
make -j 8 install-tiledb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above.

ldconfig
cd ../..
rm -rf tiledb
Expand Down
5 changes: 2 additions & 3 deletions tools/testLocalPrebuilt.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,8 @@ mkdir tiledb
cd TileDB-${ver}
mkdir build
cd build
../bootstrap --prefix=../../tiledb --disable-tbb
make -j4
make -C tiledb install
../bootstrap --prefix=../../tiledb
make -j4 install-tiledb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a more local test file. While we are at it, would you mind removing --disable-tbb ?


## cleanup
cd ../..
Expand Down
Loading