Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move one function (plus one helper) to deprecation.cpp #699

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

eddelbuettel
Copy link
Contributor

This PR catches up on the recently-merged TileDB Core PR 4879 (which deprecated more C++ API access points) and moves one function (plus a helper it uses) to src/deprecated.cpp to not trigger deprecation warnings. Deprecating and replacing the call will be left for another PR.

No code or test changes.

Copy link
Member

@teo-tsirpanis teo-tsirpanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eddelbuettel eddelbuettel merged commit 3330241 into master Apr 22, 2024
8 checks passed
@eddelbuettel eddelbuettel deleted the de/sc-45721/deprecation branch April 22, 2024 13:51
@eddelbuettel eddelbuettel mentioned this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants