-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to make array close optional #630
Conversation
This pull request has been linked to Shortcut Story #37998: Permit array to remain open. |
I contemplated adding the option to |
expect_false(tiledb_array_is_open(arr)) | ||
arr <- tiledb_array(uri, keep_open=TRUE) | ||
res <- arr[] | ||
expect_true(tiledb_array_is_open(arr)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could also check expect_false(...is_open)
after manually closing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to sneak that into #631 now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit fb46da2
* Correct the incorrectly scaled down buffer size * Update NEWS and roll micro version [ci skip] * Augment test added in #630 as suggsted post-merge
This PR adds the ability to open
tiledb_array
objects with a new optionkeep_open
.