Add ability to make array close optional #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddelbuettel
requested review from
ihnorton,
aaronwolen,
johnkerl,
awenocur and
mojaveazure
|
This pull request has been linked to Shortcut Story #37998: Permit array to remain open. |
|
I contemplated adding the option to |
awenocur
approved these changes
Dec 5, 2023
mojaveazure
approved these changes
Dec 5, 2023
aaronwolen
approved these changes
Dec 5, 2023
ihnorton
reviewed
Dec 5, 2023
| expect_false(tiledb_array_is_open(arr)) | ||
| arr <- tiledb_array(uri, keep_open=TRUE) | ||
| res <- arr[] | ||
| expect_true(tiledb_array_is_open(arr)) |
There was a problem hiding this comment.
Could also check expect_false(...is_open) after manually closing?
There was a problem hiding this comment.
I am going to sneak that into #631 now.
eddelbuettel
added a commit
that referenced
this pull request
Dec 6, 2023
eddelbuettel
added a commit
that referenced
this pull request
Dec 6, 2023
* Correct the incorrectly scaled down buffer size * Update NEWS and roll micro version [ci skip] * Augment test added in #630 as suggsted post-merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to open
tiledb_arrayobjects with a new optionkeep_open.