Ensure pointers to children are in external pointer #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires access to two otherwise static functions in nanoarrow Also minor edits to src/Makevars.in for enhanced legibility
|
This pull request has been linked to Shortcut Story #29207: Refine arrow export placing pointers to children objects in external pointer. |
awenocur
approved these changes
May 22, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When exporting to an arrow 'table' most allocation were assigned to external pointers which were properly reset. The nested children object pointers were not, and this PR corrects this.
Implementing in an adapted variant to the original
nanoarrowfunction requires access to two otherwise static functions innanoarrow.cwhich are now visible. The PR also includes minor edits tosrc/Makevars.infor enhanced legibility.No interface or functionality changes, and hence no new tests.