Correct 'raw' stats export to json string interface #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddelbuettel
requested review from
ihnorton,
aaronwolen,
awenocur and
mojaveazure
|
This pull request has been linked to Shortcut Story #25087: Expose stats api. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a small cleanup. When we added 'raw' stats export, I at first did not switch to the functionality of exporting as a string. I had at first approximated that by writing to file and re-reading.
While working on the SOMA stats functionality it became a little clearer that this is a wart. So now the
*_dump()function as before emits to either stdout or a file (if filename is given), and*_raw_dump()returns a JSON string. The existing extra accessors remain but are marked deprecated and will be removed after a suitable time period.The PR also adds a small cleanup for the PR #513 that went in this morning as using OR on query conditions has only been available since 2.10.0.
No new code, no new tests.