Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage #484

Merged
merged 3 commits into from
Nov 17, 2022
Merged

Add code coverage #484

merged 3 commits into from
Nov 17, 2022

Conversation

eddelbuettel
Copy link
Contributor

This very simple PR adds coverage. This worked in the first commit, but oddly not in the second which tried to limit which directories to include (i.e. to ignore headers from TileDB Embedded which we only access to build).

No new code.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #23546: Add code coverage support.

@eddelbuettel
Copy link
Contributor Author

Thanks for the review. I will play with his a little more before I merge to see if I can get another commit reported. I am a little fearful that my change may accidentally have disabled CI collection or aggregation -- I vaguely recall this is as finicky (going back to the Travis CI days...).

@eddelbuettel
Copy link
Contributor Author

Looks like it was just laggy.

@eddelbuettel eddelbuettel merged commit 425e0a5 into master Nov 17, 2022
@eddelbuettel eddelbuettel deleted the de/sc-23546/code_coverage branch November 17, 2022 02:04
eddelbuettel added a commit that referenced this pull request Nov 18, 2022
eddelbuettel added a commit that referenced this pull request Nov 24, 2022
eddelbuettel added a commit that referenced this pull request Nov 28, 2022
eddelbuettel added a commit that referenced this pull request Nov 29, 2022
* Default sparse read via tiledb_array to UNORDERED

* Use nchar(layout) not length, and wrap in isTRUE for comparison

* Update NEWS.md for #483, #484, #485, and #487

* Update NEWS for #488 [ci skip]

* Roll micro release to 0.16.0.3 [ci skip]

* Add codecov.yml to .Rbuildignore

* Tighten one version-based test exclusion
@eddelbuettel eddelbuettel mentioned this pull request Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants