Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine query conditions #447

Merged
merged 10 commits into from
Jul 15, 2022
Merged

Conversation

eddelbuettel
Copy link
Contributor

This PR extends support for query conditions to dense arrays (which requires queries of only attributes) and polishes one or two rough corners in doing so. A new example has been added, as has a test.

The example contains a sample query on an attribute in a dense array (which we write to memfs)

> tiledb_array(uri, return_as="data.frame", extended=FALSE,  
+                     query_condition=parse_query_condition(Temp > 90))[]
   Ozone Solar.R Wind Temp
1     NA     259 10.9   93
2     NA     250  9.2   92
3     97     267  6.3   92
4     97     272  5.7   92
5     NA     291 14.9   91
6     NA     222  8.6   92
7     76     203  9.7   97
8    118     225  2.3   94
9     84     237  6.3   96
10    85     188  6.3   94
11    96     167  6.9   91
12    78     197  5.1   92
13    73     183  2.8   93
14    91     189  4.6   93
> 
``

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #19523: Refinements for QueryConditions.

Copy link
Member

@aaronwolen aaronwolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I noted one possible typo.

inst/examples/quickstart_dense_memfs.R Outdated Show resolved Hide resolved
@eddelbuettel eddelbuettel merged commit 8014da1 into master Jul 15, 2022
@eddelbuettel eddelbuettel deleted the de/sc-19523/query_cond_refinement branch July 15, 2022 14:59
@eddelbuettel eddelbuettel mentioned this pull request Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants