Refine unit tests setup #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #19055: Condition one timetravel test on CI environment variable. |
ihnorton
approved these changes
Jun 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two small refinements for unit tests in order to avoid 'spurious' failures at CRAN.
One time travel test seen to fail occassinally on at least two system in one spot towards the end of a test file is made conditional on environment variable
CIensuring it still runs in e.g. GitHub Actions. A second test file is conditoned on not running on ancient Windows Server instances as is already done with most other test files, this affects only R-oldrel on Windows.No code changes.